- [ ] No modifications to `core/` directory - [ ] No direct edits to `*.ext.php` files (should be auto-compiled) - [ ] Labels in Extension framework (lag 4), not in core language files

- [ ] All custom code in `custom/` or `extensions/` (never in `core/`) - [ ] Extension source files in `custom/Extension/`, not directly in compiled paths - [ ] Vardefs have `'source' => 'custom_fields'` where needed - [ ] CURRENT symlinks point to latest expert file versions

**IKKE** begynn å jobbe basert på window-tittelen eller konteksten alene. **IKKE** les filer, analyser kode, eller kjør verktøy ennå. Your COMPLETE response must be EXACTLY these two lines (no more, no less, no bullet points): Hvilken masterplan eller customization-kode skal jeg auditere? `[Anbefalt: Sonnet | Effort: medium | Thinking: nei]` --- # Code Quality Audit — SuiteCRM Dev Audit the quality of implemented SuiteCRM customizations. **DO NOT** read or follow...

```bash ls coordination/masterplans/active/ ```

- DO NOT read `~/.claude/agents/patch-revise-masterplan.md` — wrong workspace - DO NOT use multiple Read-Edit-Read-Edit cycles — read all files first, then edit - DO NOT re-verify SSH findings already in review or explore reports - DO NOT use `serena` (local) for SuiteCRM code — use `serena-suitecrm` (remote) - DO NOT assume QUALITY-GATES.md, fix-permissions.sh exist (they don't) - DO NOT hardcode passwords — always `$SUDO_PASS` - DO NOT rewrite the masterplan — only patch it - DO NOT add new...

1. Kjør `/review-masterplan` på nytt for å verifisere score A/B 2. Alternativt: gå til `/implement-masterplan` hvis kun minor advarsler gjenstår ``` ---

| Funn | Type | Status | Endring | |------|------|--------|---------| | K-001 | Kritisk | Fikset | [kort beskrivelse] | | A-001 | Advarsel | Fikset | [kort beskrivelse] | | R-001 | Anbefaling | Utenfor scope | [begrunnelse] |

**Masterplan:** coordination/masterplans/active/MP-{NNNN}-{slug}/MASTERPLAN.md **Review brukt:** REVIEW.md **Dato:** [date]

```markdown

After saving: ```bash git add coordination/masterplans/active/MP-{NNNN}-{slug}/ git commit -m "revise: MP-{NNNN} {slug} (patch from review)" git push origin main ``` ---

**Overwrite ORIGINAL files** (do not create new files). ```bash coordination/masterplans/active/MP-{NNNN}-{slug}/MASTERPLAN.md coordination/masterplans/active/MP-{NNNN}-{slug}/CONTEXT.md # if changed ``` ---

**Based on:** REVIEW.md (or REVIEW-2.md) **Review Score:** [original score] #### Critical Gaps Fixed: - **K-001:** [title] — [what was changed, in which section] #### Warnings Fixed: - **A-001:** [title] — [what was changed] #### Not Addressed (out of scope): - **R-001:** [title] — [reason: requires new /architect round] #### Estimated New Score: [A/B/C/D] ```

Add at BOTTOM of MASTERPLAN.md: ```markdown ---

**MINIMAL CHANGE PRINCIPLE:** - Fix only what review flagged - Keep everything review did NOT flag - Use same style and format as existing masterplan - No structural reorganization - No scope additions **For each K-xxx/A-xxx finding:** 1. Identify exact section in masterplan 2. Make smallest change that resolves the problem 3. Note change in revision log (Step 5)

3 MCP servers available — use them in this priority: **suitecrm MCP** — only if a fix requires knowing actual field names or labels not already confirmed: | Need | MCP Tool | |------|----------| | Field exists? | `get_module_fields` | | Label key exists? | `get_language_strings` | **context7 MCP** — if a fix requires verifying an API or framework claim WITHOUT SSH-grepping source code: | Need | context7 approach | |------|----------| | Does SuiteCRM 8 support X pattern? |...

**Must fix (blocking):** - All K-xxx (critical gaps) - A-xxx that affect implementability **Should fix (improvement):** - Remaining A-xxx warnings - Simple R-xxx recommendations **Out of scope:** - R-xxx requiring new architecture analysis - Proposals that change project scope Show this categorization to user and wait for confirmation before editing.

Find files: ```bash ls coordination/masterplans/active/ ``` **Read smart — NOT everything at once:** 1. Read REVIEW.md completely (your work order — extract all K-xxx, A-xxx, R-xxx) 2. Read MASTERPLAN.md completely (understand scope + structure) 3. Read CONTEXT.md completely (gotchas, key facts) 4. Only read task files referenced by review findings **No selective reads with offset/limit** — read each file fully, once.

- Check file size before cat: `ssh suitecrm "wc -l /path/to/file"` - NEVER cat `/var/www/suitecrm/public/dist/index.html` (minified, useless) - NEVER cat `/var/www/suitecrm/public/legacy/themes/suite8/css/Dawn/style.css` (699KB) - NEVER hardcode passwords — always `$SUDO_PASS` - NEVER run parallel SSH commands that depend on each other — sequence them - Wrong: `ssh suitecrm "mkdir X" & ssh suitecrm "cp file X/"` (race condition) - Right: `ssh suitecrm "mkdir X && cp file X/"` ---

The review agent already verified facts via SSH/MCP. Do NOT re-verify what it found. - If review says "file X doesn't exist" — trust it, don't SSH-check yourself - If review says "use MCP deploy_metadata_file" — add that to the task, don't verify with SSH - Re-verification wastes tokens and produces identical results

**Read the WHOLE file before editing.** Do NOT use multiple Edit calls interleaved with Reads. ``` Correct approach: 1. Read MASTERPLAN.md ONCE (full file) 2. Read CONTEXT.md ONCE (full file) 3. Plan all changes 4. Make all Edit calls 5. Done Wrong approach (causes 12-fragment edits): Read → Edit → Read → Edit → Read → Edit → ... ```

- SuiteCRM app runs on **remote server 172.20.0.102**, NOT locally - MCP server `suitecrm` available (21 tools) — use for verification BEFORE SSH - All SSH findings from explore reports are pre-verified — trust them - Workspace path: `/var/www/suitecrm-dev/` - App path on server: `/var/www/suitecrm/`

**IKKE** begynn å jobbe basert på window-tittelen eller konteksten alene. **IKKE** les filer, analyser kode, eller kjør verktøy ennå. Your COMPLETE response must be EXACTLY these two lines (no more, no less, no bullet points): Hvilken masterplan skal revideres, og hva er review-feedbacken? `[Anbefalt: Sonnet | Effort: medium | Thinking: nei]` --- # Patch/Revise Masterplan — SuiteCRM Dev Fix critical gaps and warnings found during masterplan review. You are a **precision surgeon** — fix...

FOER du avslutter en orkestreringsesjon: 1. **Git push alle repos:** Kjoer `git log --oneline origin/main..HEAD` i alle repos der commits ble gjort. Push hvis ahead. 2. **Uncommitted side-effects:** Kjoer `git status` i alle workspaces. Rapporter modifiserte filer som IKKE var del av implementation-commits til brukeren. 3. **Masterplan-status:** Flytt ferdige masterplans til `coordination/masterplans/completed/`. 4. **Expert file-oppdateringer:** Flagg om ekspertfiler trenger oppdatering...

- [ ] KB-query: Kjoer `vendor/bin/kb query "TOPIC"` FOER implementering - [ ] Expert files: Les relevante CURRENT-*.md filer pekt paa av KB - [ ] Schema-introspeksjon: Bruk introspect/discovery-verktoy foer API-kode - [ ] Rapport: Lever ## Rapport med task_id, status, files_deployed, errors ```

Inkluder denne sjekklisten i HVER implementerings-delegering. Uten den risikerer subagenten 206 tool-kall / 139k tokens trial-and-error (faktisk observert i MP-0004 Steg 1). ```

Bruk playwright for: verifisere at CSS-endringer er synlige, at felt vises/skjules korrekt, ta screenshots etter deploy. **Bruk dette i stedet for "åpne nettleser og sjekk manuelt".**

| Verktøy | Bruk for | |---------|---------| | `resolve-library-id` | Finn riktig library ID for SuiteCRM, Angular, Symfony | | `get-library-docs` | Hent offisiell dokumentasjon uten å SSH-grep i kildekode | Bruk context7 for: SuiteCRM 8 extension docs, Angular 18 API, Symfony DI/services, Webpack Module Federation — **i stedet for å grep i source code på serveren**.

| Verktøy | Bruk for | |---------|---------| | `get_module_fields` | Les felt-definisjoner | | `deploy_metadata_file` | Deploy viewdefs (detailviewdefs, editviewdefs, listviewdefs) | | `deploy_extension_file` | Deploy Vardefs, Language, Layoutdefs | | `rebuild_extensions` | Etter Extension-endringer | | `cache_clear` | Etter metadata/config-endringer | | `set_label` | Individuelle label-endringer | | `get_language_strings` | Les gjeldende oversettelser | | `list_records` / `search_records` |...

9 MCP-servere er tilgjengelige. De tre viktigste for orkestrering:

- cat /var/www/suitecrm/public/dist/index.html (minifisert, 5KB+ inline CSS) - cat /var/www/suitecrm/public/legacy/themes/suite8/css/Dawn/style.css (699KB fil) - grep "custom.*css" index.html (matcher inline <style>-blokker) - Scripter som IKKE finnes: fix-permissions.sh, QUALITY-GATES.md, merge-angular-json - Stol på explore-rapportene — de inneholder pre-verifiserte fakta ```

- SuiteCRM versjon: 8.9.2 på /var/www/suitecrm/ - extensions/defaultExt/ eksisterer, enabled: false - public/dist/custom-overrides.css eksisterer - public/dist/index.html har <link> til custom-overrides.css - Node.js 18.20.8 installert paa server (Yarn 4.10.3, PnP) - public/legacy/custom/themes/ finnes IKKE - Eksisterende customizations: SC-0001 til SC-NNNN (sjekk CURRENT-customizations.md)

Når du delegerer til neste agent, gi alltid en "Already Verified" liste med fakta som er bekreftet og IKKE trenger re-sjekking: ```

- **ALDRI modifiser core** — kun extensions, overrides, plugins - **MCP først** — bruk suitecrm MCP for verifisering FØR SSH - **Sekvensiell deploy** — én fil om gangen til remote (ingen parallelle SSH-writes) - **Git commit etter hvert logical changeset** på remote server - **Vis fremdrift** — bruker skal se hvilken task som kjører - **ALDRI hardkod passord** — bruk alltid `$SUDO_PASS` i SSH-kommandoer - **F-04 — ALDRI kjør SSH-analyse direkte:** Du er koordinator, ikke implementør. Grep,...

Hvis en subagent leverte ufullstendig rapport og du vurderer å re-kjøre: 1. Sjekk om tasken allerede er utført via MCP eller SSH `ls`/`grep` 2. Eksempel: `ssh suitecrm "grep -q 'address_group_c' /path/to/viewdefs.php && echo DONE || echo MISSING"` 3. Kun re-kjør hvis state bekrefter at tasken IKKE er fullført

`suitecrm-specialist` har 8 knowledge files og stor instruksfil. Ved debug-delegering: - Bruk `generic-development` i stedet for `suitecrm-specialist` - Send KUN: feilmelding + relevant task-info + konkrete sjekker du vil ha gjort - **ALDRI** pass full sesjonshistorikk, "Already Verified"-lister, eller alle tidligere agent-rapporter inn i debug-prompten - Tommelregel: debug-prompt skal ikke overskride ~1500 tegn

- task_id: TASK-NNN - status: completed | failed - files_deployed: [liste med fulle stier] - errors: ingen | [feilmelding] ``` Eksempel på **ugyldig rapport** (bare MCP-gap-logging uten task-status): re-delegér.

Alle subagenter MÅ levere rapport med disse feltene. Mangler ett felt: re-kjør agenten. ```

Du kan delegere til sub-agenter for spesifikke tasks: | Task-type | Agent | |-----------|-------| | Vardef/metadata/language | `suitecrm-specialist` | | Angular extension | `suitecrm-specialist` (med knowledge-extensions.md) | | Research underveis | `explore-suitecrm` | | Debugging | `generic-development` (ikke `suitecrm-specialist` — se F-03 under) | | UI-verifisering | Playwright MCP direkte |

- Oppdater `coordination/experts/suitecrm/CURRENT-customizations.md` med SC-NNNN entries - Git commit på remote: `ssh suitecrm "cd /var/www/suitecrm && git add -A && git commit -m 'MP-NNNN: description' && git push"` - Git commit her: oppdater masterplan status til completed - Flytt masterplan til `coordination/masterplans/completed/`

- **MCP** → `get_module_fields`, `list_records` for å sjekke data/felter - **Playwright** → navigér til berørte views, ta screenshots - **SSH** → sjekk loggfiler for feil - **F-02 REGEL — testdata for UI-komponenter:** Hvis verifiseringen tester felt/komponenter som rendres basert på data (f.eks. adressefelter, relaterte felter), bruk `search_records` MCP til å finne en record MED relevante data FØR Playwright-test. En tom record gir falsk "komponent rendres ikke"-resultat.

Etter alle filer er på plass: ```bash # Extension-kompilering — bruk MCP rebuild_extensions verktøy ELLER: ssh suitecrm 'echo "$SUDO_PASS" | sudo -S -u www-data php /var/www/suitecrm/scripts/rebuild_extensions.php 2>/dev/null' # Cache clear (alle lag) ssh suitecrm 'echo "$SUDO_PASS" | sudo -S rm -rf /var/www/suitecrm/cache/themes/suite8/modules/*/ 2>/dev/null' ssh suitecrm 'echo "$SUDO_PASS" | sudo -S rm -rf /var/www/suitecrm/cache/smarty/templates_c/* 2>/dev/null' ssh suitecrm 'echo...

For hver task: 1. **Beskriv** hva som skal gjøres (vis til bruker) 2. **Implementer** — bruk suitecrm-specialist knowledge for deploy-mønster 3. **Verifiser** — MCP-query eller SSH-sjekk at filen er på plass 4. **Marker ferdig** — oppdater progress

Sorter tasks etter dependencies. Typisk rekkefølge: 1. Backend/vardefs først (DB-endringer) 2. Metadata/layoutdefs (view definitions) 3. Language/translations 4. Frontend/extension (Angular, krever build) 5. CSS/theme overrides 6. Cache clear + QR&R (samlet) 7. Verifisering (MCP + Playwright)

- Er alle tasks definert med filer, deploy-steg, og verifisering? - Er upgrade-safety analysert? - Er cache-strategi dokumentert? - Foreslå `/review-masterplan` hvis ikke gjort.

```bash ls coordination/masterplans/active/ cat coordination/masterplans/active/MP-{NNNN}-{slug}/MASTERPLAN.md ```

SuiteCRM-dev har **ingen lokal kodebase** — all kode lever på remote server (172.20.0.102). Det betyr: - **Ingen git worktrees** — vi jobber sekvensielt mot remote server - **Ingen file locks** — én agent av gangen deployer til remote - **Ingen parallell kode-skriving** — remote server er single-target Du kan likevel parallellisere **research, MCP-queries, og verifisering**.

**IKKE** begynn å jobbe basert på window-tittelen eller konteksten alene. **IKKE** les filer, analyser kode, eller kjør verktøy ennå. Your COMPLETE response must be EXACTLY these two lines (no more, no less, no bullet points): Hvilken masterplan skal orkestreres? `[Anbefalt: Sonnet | Effort: medium | Thinking: nei]` Hvis bare én aktiv masterplan finnes, vis den og spør om oppstart. --- # Orchestrator — SuiteCRM Dev Du koordinerer implementering av SuiteCRM masterplans ved å delegere tasks...

- SuiteCRM server: `ssh suitecrm` (172.20.0.102) - All Proxmox hosts (px1, pmox10, pmox15, pmox2, px3, hjemme) - All LXC containers and VMs across all locations - Networking, firewalls, reverse proxies, DNS

1. Spawn a `magitek-server-infra-ops` agent using the Agent tool with this prompt structure: ``` Oppgave: {user's request} Du jobber i /var/www/magitek-ops/ workspace. Les først ekspertfilen: coordination/experts/operations/magitek-server-ops/CURRENT.md Følg deretter instruksjonene i ~/.claude/agents/magitek-server-infra-ops.md ``` 2. The agent has SSH access to all Magitek servers and Proxmox hosts. 3. Run the agent in background if the task is independent, foreground if you need...

This command runs infrastructure operations in the **magitek-ops workspace** (`/var/www/magitek-ops/`), with full access to its expert files, coordination data, and SSH configurations.